fix: content claims derives #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View stack outputs
|
|
Going to merge as I need this fix in upload service! |
alanshaw
pushed a commit
that referenced
this pull request
Nov 4, 2024
🤖 I have created a release *beep* *boop* --- ## [5.1.1](content-claims-v5.1.0...content-claims-v5.1.1) (2024-11-04) ### Bug Fixes * content claims derives ([#74](#74)) ([6791016](6791016)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alanshaw
added a commit
to storacha/w3up
that referenced
this pull request
Nov 28, 2024
Big oversight here, although I think the original intention was to have the client publish these so perhaps not. Anyways, since no location claims are being published the gateway cannot fetch an index and serve bytes quickly. It has to get a location claim for every single block using the old dynamodb. Being able to use the index will result in a speed increase for serving content via the gateway. Depends on storacha/content-claims#74 for passing tests. --------- Co-authored-by: Petra Jaros <peeja@peeja.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default derives function has very basic loose equality checks on caveat fields. Turns out this doesn't allow the service to be invoked for most of the defined capabilities when the issuer has been delegated a capability (i.e. when not using the service key to self sign the invocation). When using a delegated capability the derives function is called to figure out if you have violated any constraints.
Luckily we didn't expose this publically and we have been using the service key to sign invocations so this hasn't come up yet.