feat: Improved layout styling, and other tales #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be highly duplicated from `SidebarLayout`, but isn't itself used at all.
Peeja
changed the title
alanshaw
approved these changes
Aug 2, 2024
hannahhoward
pushed a commit
that referenced
this pull request
Sep 20, 2024
🤖 I have created a release *beep* *boop* --- ## [1.10.0](w3console-v1.9.1...w3console-v1.10.0) (2024-09-20) ### Features * change email ([7c7beb7](7c7beb7)) * **copy:** Add missing comma ([#115](#115)) ([97f1ac3](97f1ac3)) * Improved layout styling, and other tales ([#114](#114)) ([d0a2208](d0a2208)) * more styles ([d4e8efa](d4e8efa)) * styles for upload page ([6c54798](6c54798)) * trigger deploy ([a8f1089](a8f1089)) * wording ([ffe9b1b](ffe9b1b)) ### Bug Fixes * apostrophe ([681b9b8](681b9b8)) * check ref ([f406ac9](f406ac9)) * deploy-storacha.yml needs to use the new main branch ([#122](#122)) ([65644c8](65644c8)) * deploy.yml needs to use the old-main branch ([#120](#120)) ([713af05](713af05)) * quotes ([bcf209b](bcf209b)) * **space-creator:** check provision result before proceeding ([#119](#119)) ([5ea5940](5ea5940)) * use correct branch name ([f81e090](f81e090)) * use main branch ([698974b](698974b)) ### Other Changes * add storacha deploy action ([39345e6](39345e6)) * Set `packageManager` ([#117](#117)) ([c9436fc](c9436fc)) * update deploy name ([f7c1340](f7c1340)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fforbeck
pushed a commit
to storacha/upload-service
that referenced
this pull request
Feb 5, 2025
🤖 I have created a release *beep* *boop* --- ## [1.10.0](storacha/console@w3console-v1.9.1...w3console-v1.10.0) (2024-09-20) ### Features * change email ([7c7beb7](storacha/console@7c7beb7)) * **copy:** Add missing comma ([#115](storacha/console#115)) ([97f1ac3](storacha/console@97f1ac3)) * Improved layout styling, and other tales ([#114](storacha/console#114)) ([d0a2208](storacha/console@d0a2208)) * more styles ([d4e8efa](storacha/console@d4e8efa)) * styles for upload page ([6c54798](storacha/console@6c54798)) * trigger deploy ([a8f1089](storacha/console@a8f1089)) * wording ([ffe9b1b](storacha/console@ffe9b1b)) ### Bug Fixes * apostrophe ([681b9b8](storacha/console@681b9b8)) * check ref ([f406ac9](storacha/console@f406ac9)) * deploy-storacha.yml needs to use the new main branch ([#122](storacha/console#122)) ([65644c8](storacha/console@65644c8)) * deploy.yml needs to use the old-main branch ([#120](storacha/console#120)) ([713af05](storacha/console@713af05)) * quotes ([bcf209b](storacha/console@bcf209b)) * **space-creator:** check provision result before proceeding ([#119](storacha/console#119)) ([5ea5940](storacha/console@5ea5940)) * use correct branch name ([f81e090](storacha/console@f81e090)) * use main branch ([698974b](storacha/console@698974b)) ### Other Changes * add storacha deploy action ([39345e6](storacha/console@39345e6)) * Set `packageManager` ([#117](storacha/console#117)) ([c9436fc](storacha/console@c9436fc)) * update deploy name ([f7c1340](storacha/console@f7c1340)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mainly a sweep of uses of
h-screen, as it was breaking on viewports shorter than the page contents, which was particularly nasty on the Pricing page, which is long. I've also:Unfortunately, we don't have Storybook and Chromatic (or similar) to see all the diffs, but I've screenshotted what I could. Note that these are all full-page screenshots; the fact that the befores are cut off at the top is exactly the problem I was solving here. 🙂
Plenty of this is subjective; thoughts, feedback, and corrections are more than welcome.
Before
After