Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(repo): update for the documentation URL example #2258

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

ObjectIsAdvantag
Copy link
Contributor

Fixes #[ISSUE_NUMBER].

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

If indicated yes above, please describe the breaking change(s).

Remove this quote before creating the PR.

Screenshots

If applicable, add screenshots or gifs to help demonstrate the changes. If not applicable, remove this screenshots section before creating the PR.

Additional context

The documentation URL did not align with the example.

@ObjectIsAdvantag ObjectIsAdvantag requested a review from a team as a code owner August 28, 2022 09:38
Copy link
Contributor

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, thanks for picking up on that error!

@heitortsergent
Copy link
Contributor

@ObjectIsAdvantag I approved the PR but there's a lint check that's failing because of the linting we do in the Spectral repo.

Would you mind updating the PR title, and the commit message so it follows our guidelines? I believe if you change the PR title to:

docs(repo): update for the documentation URL example

And the commit message to:

docs(repo): update for the documentation URL example

All checks should pass and we can get this merged. :)

I'm also happy to make those changes for you if you're ok with it!

@P0lip P0lip changed the title Update for the documentation URL example docs(repo): update for the documentation URL example Aug 29, 2022
@P0lip P0lip merged commit 1057287 into stoplightio:develop Aug 29, 2022
@ObjectIsAdvantag ObjectIsAdvantag deleted the patch-1 branch September 8, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants