-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(repo): add gitlab instructions to ci docs #2221
Conversation
a134183
to
2c19359
Compare
I've changed the PR title to try to match the expectations of the lint. I'm not sure that those dead link errors are from my changes though, and I don't have permissions to re-run the actions :) |
Thank you for this change, lets try and get it merged. The commit is failing because commits need to match the same convention as the PR titles, so if you could amment your commit to slap
|
Hmm, so it looks like |
cac5bde
to
c4805ed
Compare
Ok, sorry about all this, some recent changes have made this a bit hectic and we need to see if we can loosen the strictness of this linting.
This should work. It likes things lowercase, and it needs the right "scope", so can be any of those scopes it suggests: rulesets, core, etc. Repo seems close enough. |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments with small changes, thanks for putting this together!
when: always | ||
reports: | ||
junit: $CI_PROJECT_DIR/spectral-report.xml | ||
expire_in: 2 weeks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with GitLab CI/CD but I tried to copy/paste this script and it was throwing an error for expire_in
. I checked their docs and it looks like that property needs to be under artifacts
instead of reports
maybe?
OK, because of the issue with the commit message, I've forced-pushed a squashed commit which includes the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
c4ccffb
to
718c920
Compare
Checklist
Does this PR introduce a breaking change?