Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ruleset-migrator): order of functions property should not matter #2014

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Dec 29, 2021

Right now, if you place functions somewhere below rules, you'll see void 0 inserted.

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip force-pushed the fix/ruleset-migrator/undefined-fn branch from 7b07ce5 to 269641f Compare December 29, 2021 21:31
@P0lip P0lip self-assigned this Dec 29, 2021
@P0lip P0lip added the t/bug Something isn't working label Dec 29, 2021
@P0lip P0lip force-pushed the fix/ruleset-migrator/undefined-fn branch from 3a26bb2 to e7f6530 Compare December 29, 2021 21:46
@P0lip P0lip marked this pull request as ready for review December 29, 2021 21:56
@P0lip P0lip changed the base branch from develop to chore/ruleset-migrator/cleaner-cjs-output January 3, 2022 14:01
@P0lip P0lip mentioned this pull request Jan 3, 2022
4 tasks
Base automatically changed from chore/ruleset-migrator/cleaner-cjs-output to develop January 3, 2022 15:40
@P0lip P0lip force-pushed the fix/ruleset-migrator/undefined-fn branch from 0bcc848 to 4fd3e4f Compare January 3, 2022 15:56
@P0lip P0lip force-pushed the fix/ruleset-migrator/undefined-fn branch from 4fd3e4f to f11dff8 Compare January 3, 2022 16:11
@P0lip P0lip requested review from domagojk and mpodlasin January 3, 2022 20:45
Copy link
Contributor

@domagojk domagojk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bueno! Works now 💪

@P0lip P0lip enabled auto-merge (squash) January 5, 2022 13:23
@P0lip P0lip merged commit a29a204 into develop Jan 5, 2022
@P0lip P0lip deleted the fix/ruleset-migrator/undefined-fn branch January 5, 2022 13:26
stoplight-bot pushed a commit that referenced this pull request Jan 5, 2022
# [@stoplight/spectral-ruleset-migrator-v1.7.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-migrator-v1.7.0...@stoplight/spectral-ruleset-migrator-v1.7.1) (2022-01-05)

### Bug Fixes

* **ruleset-migrator:** order of functions property should not matter ([#2014](#2014)) ([a29a204](a29a204))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-ruleset-migrator-v1.7.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants