-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): export schema definition #1998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Let's just re-export it under a different name to avoid confusion.
packages/core/src/ruleset/index.ts
Outdated
@@ -1,6 +1,6 @@ | |||
export { assertValidRuleset, RulesetValidationError } from './validation'; | |||
export { getDiagnosticSeverity } from './utils'; | |||
export { createRulesetFunction } from './rulesetFunction'; | |||
export { createRulesetFunction, SchemaDefinition } from './rulesetFunction'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export { createRulesetFunction, SchemaDefinition } from './rulesetFunction'; | |
export { createRulesetFunction, SchemaDefinition as RulesetFunctionSchemaDefinition } from './rulesetFunction'; |
Actually the changes you made yesterday for studio |
991267c
to
94802f6
Compare
Yeah, was about to say we're probably good in terms of Studio, but it won't hurt to have that exported. |
🎉 This PR is included in version @stoplight/spectral-core-v1.8.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Needed for https://github.com/stoplightio/platform-internal/issues/9297
Checklist
Does this PR introduce a breaking change?