Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): export schema definition #1998

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Conversation

mallachari
Copy link

Needed for https://github.com/stoplightio/platform-internal/issues/9297

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@mallachari mallachari requested a review from P0lip December 13, 2021 14:17
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Let's just re-export it under a different name to avoid confusion.

@@ -1,6 +1,6 @@
export { assertValidRuleset, RulesetValidationError } from './validation';
export { getDiagnosticSeverity } from './utils';
export { createRulesetFunction } from './rulesetFunction';
export { createRulesetFunction, SchemaDefinition } from './rulesetFunction';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export { createRulesetFunction, SchemaDefinition } from './rulesetFunction';
export { createRulesetFunction, SchemaDefinition as RulesetFunctionSchemaDefinition } from './rulesetFunction';

@mallachari
Copy link
Author

Actually the changes you made yesterday for studio RuleFunctionOptions solve the problem so we might not need that type for now. Unless you think that it may be better to use it instead or might be useful in future.

@mallachari mallachari force-pushed the chore/core/export-types branch from 991267c to 94802f6 Compare December 14, 2021 13:06
@mallachari mallachari requested review from P0lip December 14, 2021 13:11
@P0lip
Copy link
Contributor

P0lip commented Dec 14, 2021

Actually the changes you made yesterday for studio RuleFunctionOptions solve the problem so we might not need that type for now. Unless you think that it may be better to use it instead or might be useful in future.

Yeah, was about to say we're probably good in terms of Studio, but it won't hurt to have that exported.

@P0lip P0lip merged commit 2fd923e into develop Dec 14, 2021
@P0lip P0lip deleted the chore/core/export-types branch December 14, 2021 13:59
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-core-v1.8.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants