feat(ruleset-bundler): add ruleset loader #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
feat/ruleset-bundler/add-loader
branch
from
61c7bad to
5b0cf6a
Compare
marbemac
reviewed
Dec 13, 2021
.circleci/config.yml
Outdated
| @@ -72,7 +72,7 @@ commands: | |||
| - run: yarn pretest | |||
| - run: | |||
| name: Run node tests | |||
| command: yarn test.jest --coverage --maxWorkers=<< parameters.max-workers >> | |||
There was a problem hiding this comment.
This removal of --coverage intentional? (ok if it is, just double checking)
There was a problem hiding this comment.
Yeah, it's already gone in develop branch
packages/ruleset-bundler/README.md
Outdated
|
|
||
| ## Loading YAML/JSON Ruleset | ||
|
|
||
| It is assumed you have [@stoplight/spectral-ruleset-migrator](https://www.npmjs.com/package/@stoplight/spectral-ruleset-migrator) installed. |
There was a problem hiding this comment.
Any reason to not have this as a dependency if it's always required? Env issue, dedupe issue, something else?
There was a problem hiding this comment.
Any reason to not have this as a dependency if it's always required? Env issue, dedupe issue, something else?
hmmm, yeah, we could have it installed, why not.
Comment on lines
+22
to
+24
| "default": "./dist/loader/node.js", | ||
| "node": "./dist/loader/node.js", | ||
| "browser": "./dist/loader/browser.js" |
| export async function bundle(rulesetFile: string, bundleOptions: BundleOptions, { fs }: IO): Promise<string> { | ||
| try { | ||
| if (isBasicRuleset(rulesetFile)) { | ||
| const migratedRuleset = await migrateRuleset(rulesetFile, { |
There was a problem hiding this comment.
Ah I think I see - migrateRuleset naming confused me. More like a ruleset transformer in this case, to transform from plain object format to esm format.
stoplight-bot
pushed a commit
that referenced
this pull request
Dec 15, 2021
# [@stoplight/spectral-ruleset-bundler-v1.1.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-bundler-v1.0.1...@stoplight/spectral-ruleset-bundler-v1.1.0) (2021-12-15) ### Features * **ruleset-bundler:** add ruleset loader ([#1988](#1988)) ([a2c84dc](a2c84dc))
stoplight-bot
pushed a commit
that referenced
this pull request
Dec 15, 2021
# [@stoplight/spectral-ruleset-migrator-v1.6.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-migrator-v1.5.2...@stoplight/spectral-ruleset-migrator-v1.6.0) (2021-12-15) ### Features * **ruleset-bundler:** add ruleset loader ([#1988](#1988)) ([a2c84dc](a2c84dc))
stoplight-bot
pushed a commit
that referenced
this pull request
Dec 15, 2021
# [@stoplight/spectral-ruleset-bundler-v1.1.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-bundler-v1.0.1...@stoplight/spectral-ruleset-bundler-v1.1.0) (2021-12-15) ### Features * **ruleset-bundler:** add ruleset loader ([#1988](#1988)) ([a2c84dc](a2c84dc))
stoplight-bot
pushed a commit
that referenced
this pull request
Dec 15, 2021
# [@stoplight/spectral-ruleset-migrator-v1.6.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-migrator-v1.5.2...@stoplight/spectral-ruleset-migrator-v1.6.0) (2021-12-15) ### Features * **ruleset-bundler:** add ruleset loader ([#1988](#1988)) ([a2c84dc](a2c84dc))
stoplight-bot
pushed a commit
that referenced
this pull request
Dec 15, 2021
# [@stoplight/spectral-ruleset-bundler-v1.1.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-bundler-v1.0.1...@stoplight/spectral-ruleset-bundler-v1.1.0) (2021-12-15) ### Features * **ruleset-bundler:** add ruleset loader ([#1988](#1988)) ([a2c84dc](a2c84dc))
|
🎉 This PR is included in version @stoplight/spectral-ruleset-bundler-v1.1.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
stoplight-bot
pushed a commit
that referenced
this pull request
Dec 15, 2021
# [@stoplight/spectral-ruleset-migrator-v1.6.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-migrator-v1.5.2...@stoplight/spectral-ruleset-migrator-v1.6.0) (2021-12-15) ### Features * **ruleset-bundler:** add ruleset loader ([#1988](#1988)) ([a2c84dc](a2c84dc))
|
🎉 This PR is included in version @stoplight/spectral-ruleset-migrator-v1.6.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1956
Checklist
Does this PR introduce a breaking change?