[WIP] Plug leak #1890
Closed
[WIP] Plug leak #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulltoken
force-pushed
the
ntk/leak
branch
2 times, most recently
from
acde342 to
ae81d91
Compare
radzserg
reviewed
Sep 17, 2021
packages/cli/src/operations.ts
Outdated
| if (isOpenAPI2(result)) operations = transformOas2Operations(result); | ||
| else if (isOpenAPI3(result)) operations = transformOas3Operations(result); | ||
| else if (isPostmanCollection(result)) operations = transformPostmanCollectionOperations(result); | ||
| else throw new Error('Unsupported document format'); | ||
|
|
||
| operations.forEach((op, i, ops) => { | ||
| if (op.request !== undefined) { |
There was a problem hiding this comment.
Yeah I see your point, make sense
|
@radzserg Hmmm. I've been sidetracked by another topic and thus haven't had the time to fix all the tests. I've still got some work in that area. However, even if the CI doesn't pass, you might be willing to take an early peek at this WIP. Feedback would be very welcome ;-) |
7 tasks
|
Superceded by #1892 |
ghost
reopened this
|
Closing due to fix: #1892 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1881
Summary
Replace this with something that explains what this PR is for and why it matters.
Checklist
Screenshots
If applicable, add screenshots or gifs to help demonstrate the changes. If not applicable, remove this screenshots
section before creating the PR.
Additional context
Add any other context about the pull request here. Remove this section if there is no additional context.