Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin-exclusive share-management page #461

Merged
merged 6 commits into from
May 3, 2024

Conversation

SFGrenade
Copy link
Contributor

Allows to view a list of all shares of all users, with the user who owns the share next to it.

Partially allows #124

@stonith404
Copy link
Owner

Thank you for your contribution, it's a great addition.

I've updated the icon to match the existing share icon for consistency. Additionally, I've added the share size to the list and removed the description to avoid cluttering it.

It looks ready to merge for me, what do you think?

@SFGrenade
Copy link
Contributor Author

It does look ready to merge for me as well

@stonith404 stonith404 merged commit 3b1c9f1 into stonith404:main May 3, 2024
1 check passed
@droplinxuser
Copy link

Thanks for the great feature.
But it seems to conflict when a hosted app allows guest uploads?

image

@SFGrenade
Copy link
Contributor Author

oh, reverse shares? i didnt account for those

@droplinxuser
Copy link

Yes, I do have some reverse shares as well.

@stonith404
Copy link
Owner

I forgot to test this as well. However, it should be fixed now in v0.24.1.

@droplinxuser
Copy link

But it seems to conflict when a hosted app allows guest uploads?

This is working fine now.
Thanks a lot.

Similar request: please add pagination :).

@stonith404
Copy link
Owner

@droplinxuser Yeah, that's currently only a basic implementation. Pagination, filtering, and ordering would be nice too. Feel free to create a feature request.

@droplinxuser
Copy link

Sure, added :)
#468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants