fix: disable email login if ldap is enabled

stonith404 · Sep 18, 2024 · d9cfe69 · d9cfe69
1 parent 67a0fc6
commit d9cfe69
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/frontend/src/components/auth/SignInForm.tsx b/frontend/src/components/auth/SignInForm.tsx
@@ -80,7 +80,9 @@ const SignInForm = ({ redirectPath }: { redirectPath: string }) => {
     useState(false);
 
   const validationSchema = yup.object().shape({
-    emailOrUsername: yup.string().required(t("common.error.field-required")),
+    emailOrUsername: config.get("ldap.enabled")
+      ? yup.string().matches(/^[^@]+$/, t("signIn.error.invalid-username"))
+      : yup.string().required(t("common.error.field-required")),
     password: yup
       .string()
       .min(8, t("common.error.too-short", { length: 8 }))
@@ -172,8 +174,16 @@ const SignInForm = ({ redirectPath }: { redirectPath: string }) => {
             })}
           >
             <TextInput
-              label={t("signin.input.email-or-username")}
-              placeholder={t("signin.input.email-or-username.placeholder")}
+              label={
+                config.get("ldap.enabled")
+                  ? t("signup.input.username")
+                  : t("signin.input.email-or-username")
+              }
+              placeholder={
+                config.get("ldap.enabled")
+                  ? t("signup.input.username.placeholder")
+                  : t("signin.input.email-or-username.placeholder")
+              }
               {...form.getInputProps("emailOrUsername")}
             />
             <PasswordInput

diff --git a/frontend/src/i18n/translations/en-US.ts b/frontend/src/i18n/translations/en-US.ts
@@ -50,6 +50,7 @@ export default {
   "signIn.oauth.microsoft": "Microsoft",
   "signIn.oauth.discord": "Discord",
   "signIn.oauth.oidc": "OpenID",
+  "signIn.error.invalid-username": "Invalid username",
 
   // END /auth/signin