-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tianmu): fix up the incompatible type #1824
fix(tianmu): fix up the incompatible type #1824
Conversation
This pull request's title should follow requirements next. @RingsC please check it 👇. Valid format:
Valid types:
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1824 +/- ##
===================================================
- Coverage 55.04% 55.01% -0.03%
===================================================
Files 2031 2031
Lines 431436 431442 +6
===================================================
- Hits 237495 237377 -118
- Misses 193941 194065 +124
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1) In result value setup phase, it only deals with num, but in some case, some non-num types involved, therefore, we should also deal with these types. 2) To fixup the boundary of the error codes.
Summary about this PR
In result value setup phase, it only deals with num, but in some case, some non-num types involved, therefore, we should also deal with these types.
Issue Number: close #1808 #1788
Tests Check List
Changelog
Documentation