Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): backport EXTRACT() function error stoneatom#1691 #1799

Merged
merged 1 commit into from
May 21, 2023
Merged

fix(tianmu): backport EXTRACT() function error stoneatom#1691 #1799

merged 1 commit into from
May 21, 2023

Conversation

Double0101
Copy link
Collaborator

Summary about this PR

Issue Number: close #1691 #1681

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label May 18, 2023
@Double0101
fix(tianmu): backport EXTRACT() function error stoneatom#1691
f01d7b9 
Cause:
  In the function  VirtualColumnAlreadyExists() return incorrect result
when extract(xxx a), extract(xxx b), it judge the second extract same as
the first, than remove it
Solution:
  fix the operator== function in mysql_expression.
hustjieke
hustjieke approved these changes May 21, 2023
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hustjieke
hustjieke approved these changes May 21, 2023
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hustjieke hustjieke merged commit 84e5b2b into stoneatom:stonedb-8.0-dev May 21, 2023
@Double0101 Double0101 deleted the union-error branch June 8, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustjieke hustjieke hustjieke approved these changes

Assignees
No one assigned
Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Double0101 @hustjieke