Skip to content

Commit

Permalink
fix(core): fix bug: The instance occasionally crashes if both fields …
Browse files Browse the repository at this point in the history
…specified for an equi-join are of the string data types (#1476)
  • Loading branch information
wisehead committed Apr 4, 2023
1 parent 7484c58 commit d3f8cdb
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion storage/tianmu/core/parallel_hash_join.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ namespace Tianmu {
namespace core {
namespace {
const int kJoinSplittedMinPacks = 5;
const int kTraversedPacksPerFragment = 30;
// bug 1476: change this threhold from 30 to INT_MAX32 to disable the parallel hash join
// because the result is sometimes wrong if parallel hash join is enabled.
// we'll re-enable the hash join later if the bug is fixed in near future.
const int kTraversedPacksPerFragment = INT_MAX32;

int EvaluateTraversedFragments(int packs_count) {
const int kMaxTraversedFragmentCount = 8;
Expand Down

0 comments on commit d3f8cdb

Please sign in to comment.