Support matching suggestions on spacebar

[ndrjkvc]

Use-case/Problem

draft-js-plugins#1048

Implementation

Pass a matching function(with suggestions and lastSearchValue as arguments) from config as a prop to MentionSuggestions component. Use this function after spacebar is pressed to find a matching solution if there is one.

[szist]

can't you just point npm to a subfolder of a github repo?
like:
github:stocktwits/draft-js-plugins/draft-js-mention-plugin ?

I would prefer not installing the whole repo as a runtime dependency everywhere :(

[szist]

nevermind, you can't: npm/npm#2974
Although there is a mention of gitpkg in a similar issue for yarn: yarnpkg/yarn#4725 see commit yarnpkg/yarn#4725 (comment) Might be good to investigate, but we might need yet-another repo from @afahy if we want to push the built package into it's own lib :)

[szist]

fun fact, that issue for npm is 7 years old, so I don't think anything will change soon.

[szist]

@ndrjkvc Anyhow, if we just want to move on, you would have to install the whole draft-js-plugins and if you want to use your built library should be able to just include:
import createMentionPlugin from "draft-js-plugins/draft-js-mention-plugin"

[ndrjkvc]

@ndrjkvc Anyhow, if we just want to move on, you would have to install the whole draft-js-plugins and if you want to use your built library should be able to just include:
import createMentionPlugin from "draft-js-plugins/draft-js-mention-plugin"

That does not work, the plugins subfolders are empty after draft-js-plugins install (not really empty, they contain changelog, license, and readme)

[ndrjkvc]

But there may be something we can write into package.json to let npm know it should download that folder fully. @szist

[szist]

But there may be something we can write into package.json to let npm know it should download that folder fully. @szist

you should add/create a .npmignore file, so that it doesn't use the .gitignore to remove all libs. See https://github.com/stocktwits/web-shared/blob/develop/.npmignore vs https://github.com/stocktwits/web-shared/blob/develop/.gitignore

[szist]

do we still need the lib/*.js in git and the files in package.json ?

[ndrjkvc]

do we still need the lib/*.js in git and the files in package.json ?

No. 🎉