Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix manager reset action when no allowed values for reset type are provided #279

Merged
merged 1 commit into from
Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions redfish/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -438,10 +438,7 @@ func ListReferencedManagers(c common.Client, link string) ([]*Manager, error) {
func (manager *Manager) Reset(resetType ResetType) error {
if len(manager.SupportedResetTypes) == 0 {
// reset directly without reset type. HPE server has the behavior
t := struct {
Action string
}{Action: "Manager.Reset"}
return manager.Post(manager.resetTarget, t)
return manager.Post(manager.resetTarget, struct{}{})
}
// Make sure the requested reset type is supported by the manager.
valid := false
Expand Down
45 changes: 45 additions & 0 deletions redfish/manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -379,3 +379,48 @@ func TestManagerUpdate(t *testing.T) {
t.Errorf("Unexpected DateTimeLocalOffset update payload: %s", calls[0].Payload)
}
}

func TestManagerReset(t *testing.T) {
var result Manager
err := json.NewDecoder(strings.NewReader(managerBody)).Decode(&result)

if err != nil {
t.Errorf("Error decoding JSON: %s", err)
}

testClient := &common.TestClient{}
result.SetClient(testClient)

// happy path
result.SupportedResetTypes = []ResetType{GracefulRestartResetType}
err = result.Reset(GracefulRestartResetType)
if err != nil {
t.Errorf("Error making Reset call: %s", err)
}

calls := testClient.CapturedCalls()

if !strings.Contains(calls[0].Payload, "ResetType:GracefulRestart") {
t.Errorf("Unexpected ResetType in payload: %s", calls[0].Payload)
}

// expect error when use non-supported reset type
result.SupportedResetTypes = []ResetType{GracefulRestartResetType}
err = result.Reset(ForceRestartResetType)
if err == nil {
t.Errorf("No error when expected on Reset call: %s", err)
}

// expect empty payload when no allowed reset types
result.SupportedResetTypes = []ResetType{}
err = result.Reset(GracefulRestartResetType)
if err != nil {
t.Errorf("Error making Reset call: %s", err)
}

calls = testClient.CapturedCalls()

if calls[1].Payload != "map[]" {
t.Errorf("Unexpected payload: %s", calls[1].Payload)
}
}