Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get memeories async #209

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Fix get memeories async #209

merged 4 commits into from
Oct 21, 2022

Conversation

lorenzb07
Copy link
Contributor

this pull request fix the 204 adding the wg.Add(1) in the for loop and fix the collectionError

@lorenzb07 lorenzb07 mentioned this pull request Oct 21, 2022
Merged
stmcginnis
stmcginnis approved these changes Oct 21, 2022
View reviewed changes
Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I missed that in review too.

@stmcginnis stmcginnis merged commit a095da3 into stmcginnis:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzb07 @stmcginnis