Support event subscription and submitTestEvent for various vendors

[nwaizer]

No description provided.

[stmcginnis]

Imports still need to be cleaned up. Make sure to run make or make lint locally.

Looks like some local files were accidentally included.

References to oem code still need to be removed from the core.

[nwaizer]

Hi Sean,
Thanks again for your help on this.
0. lint now shows only this:

oem/hpe/hpe.go:8: File is not `goimports`-ed with -local github.com/stmcginnis (goimports)
	"encoding/json"
redfish/eventdestination.go:10: File is not `goimports`-ed with -local github.com/stmcginnis (goimports)
	oemZt "github.com/stmcginnis/gofish/oem/zt"
redfish/eventservice.go:9: File is not `goimports`-ed with -local github.com/stmcginnis (goimports)
	"fmt"

I tried to run goimports -w on these files, to no avail. what to do?

1. Extra files are used in testing the new function as SubscribeZT() and SendEventDell()
2. So you do not want to use a common CreateEventSubscription() to work for all three oem vendors?
3. Same for not using a common SubmitTestEvent() for all three vendors?

[nwaizer]

all done and ready to merge?

[stmcginnis]

Please remove this line. See header at top of file.

[nwaizer]

done

[stmcginnis]

This doesn't look right. Defined this way, the properties of the Status struct are direct properties of the response type. But according to the JSON in the test code, there should be a Status property of type common.Status.

So current definition is:

{
    "Health": "OK",
    "HealthRollup": "OK",
    "State": "Enabled"
}

But the example from the test JSON is:

{
    "Status": {
        "Health": "OK",
        "HealthRollup": "OK",
        "State": "Enabled"
    }
}

[nwaizer]

done

[stmcginnis]

Sorry, looking closer here and notice this isn't quite right yet either. Like the example given earlier, these calls need to be done on OEM versions of the standard objects. So you would get an EventService instance, then to access the OEM specific implementations for that you would need to get the right version. Something like:

eventService, _ := x.EventService()
ztEventService, _ := zt.FromEventService(eventService)
ztEventService.SubmitTestEvent("my message")

So there still needs to be a ZTEventService defined, then this would be a call on an instance of that object.

https://github.com/stmcginnis/gofish/blob/main/redfish/eventservice.go#L334

[nwaizer]

I think its ok now. please provide feedback if not

[stmcginnis]

Still a few issues, but I will clean up with a follow up. Thanks for working through all of this!