Fix shared reference of mutable static warning #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes this warning: warning: shared reference of mutable static is discouraged --> stm32l0xx-hal/src/signature.rs:45:40 | 45 | core::str::from_utf8_unchecked(&DEVICE_ID_STR) | ^^^^^^^^^^^^^^ shared reference of mutable static | = note: for more information, see issue #114447 <rust-lang/rust#114447> = note: reference of mutable static is a hard error from 2024 edition = note: mutable statics can be written to by multiple threads: aliasing violations or data races will cause undefined behavior = note: `#[warn(static_mut_ref)]` on by default help: shared references are dangerous since if there's any kind of mutation of that static while the reference lives, that's UB; use `addr_of!` instead to create a raw pointer
jamwaffles
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes this warning:
warning: shared reference of mutable static is discouraged
--> stm32l0xx-hal/src/signature.rs:45:40
|
45 | core::str::from_utf8_unchecked(&DEVICE_ID_STR)
| ^^^^^^^^^^^^^^ shared reference of mutable static
|
= note: for more information, see issue #114447 rust-lang/rust#114447
= note: reference of mutable static is a hard error from 2024 edition
= note: mutable statics can be written to by multiple threads: aliasing violations or data races will cause undefined behavior
= note:
#[warn(static_mut_ref)]on by defaulthelp: shared references are dangerous since if there's any kind of mutation of that static while the reference lives, that's UB; use
addr_of!instead to create a raw pointer