generic IntoAf #308
Merged
generic IntoAf #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
commented
Jan 15, 2022
|
This looks really cool. Leveraging type inference to save time looking up the correct alternate function number is a great ergonomic boom! 🎉 I'll have a deeper look later this weekend (hopefully sometime today) but at first glance this looks good |
burrbull
force-pushed
the
intoaf
branch
2 times, most recently
from
7db6509
to
d40d2dc
Compare
Sh3Rm4n
approved these changes
Jan 19, 2022
| #[derive(Debug)] | ||
| #[cfg_attr(feature = "defmt", derive(defmt::Format))] | ||
| pub struct $Gpiox; | ||
| #[doc = concat!("GPIO port ", stringify!($GPIOX), " (type state)")] |
There was a problem hiding this comment.
Nice! I assume this is the reason for the MSRV 1.52 -> 1.54 bump? Good to decrease the invocations of paste.
|
rebased |
|
LGTM. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.