Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define pin type aliases directly under gpio module #257

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Define pin type aliases directly under gpio module #257

merged 1 commit into from
Jul 21, 2021

Conversation

Piroro-hs
Copy link
Contributor

@Piroro-hs Piroro-hs closed this Jul 19, 2021
@Piroro-hs
Copy link
Contributor Author

Oops

@Piroro-hs Piroro-hs reopened this Jul 19, 2021
@Sh3Rm4n Sh3Rm4n self-requested a review July 19, 2021 11:25
Sh3Rm4n
Sh3Rm4n approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@Sh3Rm4n Sh3Rm4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your solution with the re-exports into the submodules. That makes it very clean in the generated doc 👍

@Sh3Rm4n Sh3Rm4n merged commit 2fc0ecf into stm32-rs:master Jul 21, 2021
Sh3Rm4n added a commit to Sh3Rm4n/stm32f3xx-hal that referenced this pull request Jul 21, 2021
@Sh3Rm4n
Merge pull request stm32-rs#257 from Piroro-hs/reexport-pins
f8d98f0 
Define pin type aliases directly under gpio module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sh3Rm4n Sh3Rm4n Sh3Rm4n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piroro-hs @Sh3Rm4n