Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify rotate functionality #10

Merged
merged 7 commits into from
Jun 29, 2020
Merged

Conversation

stiftcast
Copy link
Contributor

Added degrees option to enable the page(s) to be rotated either 90, 180 or 270 degrees in one go. Also fixed a bug in the logic where pages that weren't specified were getting excluded or exhibiting other weird behaviour.

Copy link
Owner

@stlehmann stlehmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me. Would you mind adding an entry to the changelog. Then your are clear for merging.

Will retain original functionality.
@stiftcast
Copy link
Contributor Author

Updated. Also made a small tweak to preserve compatibility with the original.

@stlehmann
Copy link
Owner

Thanks for this :)

@stlehmann stlehmann merged commit 5de8e8a into stlehmann:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants