Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with Java 21 #803

Merged
merged 2 commits into from
Oct 20, 2023
Merged

ci: test with Java 21 #803

merged 2 commits into from
Oct 20, 2023

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Oct 16, 2023

Add Java 21 to the build matrix

@yeikel yeikel marked this pull request as ready for review October 16, 2023 16:41
@johnjaylward
Copy link
Contributor

I have added this to PR #801

@yeikel
Copy link
Contributor Author

yeikel commented Oct 16, 2023

I have added this to PR #801

Thanks for letting me know. Your change seems to be doing two things at once and it is probably best to handle them separately as it would be easier to revert if needed

I am leaving this open for now and I'll leave it up to the maintainers to decide

@johnjaylward
Copy link
Contributor

good point, I'll keep the current 8-17 in my PR. we can use this one for ensuring 21 works without issue as well

@stleary
Copy link
Owner

stleary commented Oct 17, 2023

What problem does this code solve?
Add Java 21 to the build matrix

Risks
Low

Changes to the API?
N/A

Will this require a new release?
No

Should the documentation be updated?
No (separate ticket)

Does it break the unit tests?
N/A

Was any code refactored in this commit?
N/A

Review status
APPROVED

Starting 3-day comment window

README.md Outdated Show resolved Hide resolved
stleary
stleary previously approved these changes Oct 20, 2023
@stleary stleary merged commit 411f711 into stleary:master Oct 20, 2023
6 checks passed
@yeikel yeikel deleted the patch-2 branch October 21, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants