Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonObject.similar() number entry check bug fix #613

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Conversation

stleary
Copy link
Owner

@stleary stleary commented Jul 18, 2021

#611 reported that similar returns too soon on success when a Number entry type is checked. Fixed by returning only if the Number check fails. Added unit test to exercise the new code.

@stleary
Copy link
Owner Author

stleary commented Jul 18, 2021

What problem does this code solve?
Fixes #611 similar() returns too soon when checking Number entries

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, but unit tests were added

Was any code refactored in this commit?
No

Review status
APPROVED - By myself

Starting 3 day comment window

Copy link
Contributor

@johnjaylward johnjaylward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also correct the implementation in JSONArray

@johnjaylward
Copy link
Contributor

Also, due to the nature of the bug fix, this probably should get a new release.

@stleary
Copy link
Owner Author

stleary commented Jul 19, 2021

Forgot to check JsonArray, thanks for the heads-up @johnjaylward.
Agreed this is a good release candidate.

@stleary stleary merged commit c0e467c into master Jul 26, 2021
@stleary stleary changed the title Fixes Issue #611 JsonObject.similar() returns after number entry check JsonObject.similar() number entry check bug fix Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants