Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to tests for https://github.com/stleary/JSON-java/pull/337 #71

Merged
merged 7 commits into from
May 23, 2017
Merged

Adjustments to tests for https://github.com/stleary/JSON-java/pull/337 #71

merged 7 commits into from
May 23, 2017

Conversation

johnjaylward
Copy link
Contributor

No description provided.

@stleary
Copy link
Owner

stleary commented May 17, 2017

Thanks, will merge when stleary/JSON-java#337 is merged.

@stleary stleary changed the title Adjustments to tests for https://github.com/stleary/JSON-java/pull/337/ Adjustments to tests for https://github.com/stleary/JSON-java/pull/336/ May 17, 2017
@johnjaylward
Copy link
Contributor Author

this one is for 337, not 336.

@johnjaylward johnjaylward changed the title Adjustments to tests for https://github.com/stleary/JSON-java/pull/336/ Adjustments to tests for https://github.com/stleary/JSON-java/pull/337 May 17, 2017
@stleary
Copy link
Owner

stleary commented May 17, 2017

Sorry, just assumed this was the fix for the broken increment test in 336 (branch johnjaylward-fixSpelling), but I did not actually execute the test to make sure.

@johnjaylward
Copy link
Contributor Author

#70 fixes the increment tests

@stleary
Copy link
Owner

stleary commented May 17, 2017

Thanks, I think the comments and links are corrected now

@johnjaylward
Copy link
Contributor Author

I believe these tests cover what we need.

@stleary
Copy link
Owner

stleary commented May 18, 2017

OK to merge after stleary/JSON-java#337

@stleary stleary merged commit 93ca7b1 into stleary:master May 23, 2017
@johnjaylward johnjaylward deleted the OptimizeOpt branch July 10, 2017 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants