General Cleanup #539
Merged
General Cleanup #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleaned up mutex usage in await to eliminate a flag, and directly protect the element being modified. - Fixed a memory leak in Windows default executor and a potential leak if scheduling work fails. - Made package_task<> move-only which simplifies promise by removing promise count. - Removed unused reduction_failed error code. - Added a reduction test for future<future<void>>
FelixPetriconi
approved these changes
Mar 1, 2024
FelixPetriconi
approved these changes
Mar 1, 2024
|
|
||
| dispatch_group_async_f(detail::group()._group, | ||
| dispatch_get_global_queue(platform_priority(P), 0), | ||
| new f_t(std::move(f)), [](void* f_) { | ||
| new f_t(std::foward<F>(f)), [](void* f_) { |
The task pointer was already being deleted by a unique pointer after execution. I kept the code (with a typo fix) to ensure it is deleted in case of failure.
FelixPetriconi
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
await()to eliminate a flag and directly protect the element being modified.