Sean parent/set thread name #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation did not work on wasm, I also added Windows support. This should make it simple to provide platform specific implementations.
FelixPetriconi
approved these changes
Apr 9, 2021
| #elif defined(_MSC_VER) | ||
|
|
||
| inline void set_current_thread_name(const char* name) { | ||
| /* Should string->wstring be split out to a utility? */ |
There was a problem hiding this comment.
At the moment I don't think so, because this is the very only place to handle anything with strings explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing setting the thread name for the portable executor for wasm - also added support for windows.