Fix issue #229 #232
Merged
Fix issue #229 #232
+15
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| template <typename T> | ||
| template <typename R> | ||
| auto shared_base<T, enable_if_not_copyable<T>>::reduce(future<future<R>>&& r) -> future<R> { | ||
| return std::move(r).then([](auto&& f) { return *std::forward<future<R>>(f).get_try(); }); | ||
| return std::move(r).then([](auto&& f) { return *std::move(f).get_try(); }); |
There was a problem hiding this comment.
@FelixPetriconi - can you speak a little bit to why you made this change? I would have thought the correct line here would be std::forward<decltype(f)>(f)... why is a move correct?
There was a problem hiding this comment.
My mistake. I was looking at the signature from the reduce function and there it is an rvalue reference, that should be moved. But here, as you correctly have noticed, we are in a forwarding reference and your code would be the general solution to this. I will fix this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.