Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong version in the 1.6.0 release #363

Closed
tetsuhaut opened this issue Feb 10, 2021 · 2 comments
Closed

Wrong version in the 1.6.0 release #363

tetsuhaut opened this issue Feb 10, 2021 · 2 comments
Assignees
@FelixPetriconi
Labels
bug fixed-in-main

Comments

@tetsuhaut
Copy link

tetsuhaut commented Feb 10, 2021 •
edited
Loading

The file stlab/version.hpp states

#define STLAB_VERSION 100506
[...]
#define STLAB_LIB_VERSION "1_5_6"

The file CMakeLists.txt also indicates the 1.5.6 version.

This makes CMake refuse the instruction

find_package(stlab 1.6.0 REQUIRED)

in my own project's CMakeLists.txt file.
@FelixPetriconi
Copy link
Member

Thanks for spotting. I will fix this later today.

@FelixPetriconi FelixPetriconi self-assigned this Feb 10, 2021
FelixPetriconi added a commit to FelixPetriconi/libraries that referenced this issue Feb 10, 2021
@FelixPetriconi
Fix stlab#363
ebcf6a6
@FelixPetriconi
Copy link
Member

Fixed in 1.6.1

sean-parent pushed a commit that referenced this issue Mar 25, 2021
@FelixPetriconi
Prepare 1.6.2 release (#374)
0a7232a 
* Fix #363

* Prepare 1.6.2 release

* Update status badge and minor wording improvements
FelixPetriconi added a commit to FelixPetriconi/libraries that referenced this issue Nov 19, 2021
@FelixPetriconi
Fix stlab#363
040092f
FelixPetriconi added a commit that referenced this issue Feb 11, 2022
@FelixPetriconi
Update conan and fix #392 (#393)
89ea735 
* Fix #363

* Prepare 1.6.2 release

* Update status badge and minor wording improvements

* issue 392: The coroutine operators should use the defined executor of the future
and not the default_executor

* Update conan version because of expired certificate

* Update to more recent conan version

* Update conan for Windows too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FelixPetriconi FelixPetriconi

Labels
bug fixed-in-main
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FelixPetriconi @tetsuhaut