Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_ready_future for move-only types #220

Closed
dixlorenz opened this issue Dec 14, 2018 · 2 comments
Closed

make_ready_future for move-only types #220

dixlorenz opened this issue Dec 14, 2018 · 2 comments
Assignees
Milestone

Comments

@dixlorenz
Copy link
Contributor

This code fails to compile:

auto f = stlab::make_ready_future(std::make_unique(4));

Judging from stlab::async, the return in make_ready_future should probably be

return std::move(p.second);

@FelixPetriconi
Copy link
Member

Many thanks for spotting this. We will fix it with the next patch.

@FelixPetriconi
Copy link
Member

Fixed in 1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants