Removing some explicit NOLINT

stlab · Nov 25, 2024 · ba89f6d · FelixPetriconi · Nov 25, 2024 · ba89f6d
1 parent 15f1d5f
commit ba89f6d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/stlab/forest.hpp b/stlab/forest.hpp
@@ -106,8 +106,7 @@ struct child_iterator {
     using iterator_category = typename std::iterator_traits<I>::iterator_category;
 
     child_iterator() = default;
-    // NOLINTNEXTLINE(performance-unnecessary-value-param)
-    explicit child_iterator(I x) : _x(std::move(x)) {}
+    explicit child_iterator(const I& x) : _x(std::move(x)) {}
     template <class U>
     child_iterator(const child_iterator<U>& u) : _x(u.base()) {}
 
@@ -183,8 +182,7 @@ struct edge_iterator {
     using iterator_category = typename std::iterator_traits<I>::iterator_category;
 
     edge_iterator() = default;
-    // NOLINTNEXTLINE(performance-unnecessary-value-param)
-    explicit edge_iterator(I x) : _x(find_edge(x, Edge)) {}
+    explicit edge_iterator(const I& x) : _x(find_edge(x, Edge)) {}
     template <class U>
     edge_iterator(const edge_iterator<U, Edge>& u) : _x(u.base()) {}
 

diff --git a/stlab/forest_algorithms.hpp b/stlab/forest_algorithms.hpp
@@ -40,8 +40,7 @@ struct transcribe_iterator {
     using reference = void;
     using container_type = Container;
 
-    // NOLINTNEXTLINE(performance-unnecessary-value-param)
-    transcribe_iterator(Container& c, typename Container::iterator i) : _c{&c}, _i{std::move(i)} {}
+    transcribe_iterator(Container& c, const typename Container::iterator& i) : _c{&c}, _i{i} {}
 
     constexpr auto operator*() -> auto& { return *this; }
     constexpr auto operator++() -> auto& {