Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating token_range_t off of boost::size #124

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Migrating token_range_t off of boost::size #124

merged 7 commits into from
Aug 27, 2024

Conversation

thinlang
Copy link
Contributor

No description provided.

@sean-parent
Copy link
Member

sean-parent commented Aug 26, 2024

Reason for change? Would moving token_range_t to std::basic_string_view<unsigned char> be a cleaner option?

@thinlang
Copy link
Contributor Author

thinlang commented Aug 26, 2024

Reason for change? Would moving token_range_t to std::basic_string_view be a cleaner option?

I'm moving some Photoshop code off of boost::size. I encountered a few places where we were using boost::size on token ranges and thought it best to put a replacement closest to token_range_t rather than create a local function in Photoshop and then have 2 ways to get the size of a token range.

If I moved token range to std::basic_string_view<unsigned char>, I'd maybe need to migrate more boost than I'd anticipated but I can certainly try. Stand by.

@thinlang
Copy link
Contributor Author

Turns out moving to string_view would require a MUCH bigger change as we raw manipulate and read the first and second members of the pair.

Bryn Aspestrand added 3 commits August 26, 2024 17:10
@sean-parent sean-parent merged commit c7f6b88 into stlab:main Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants