Fixing some symbol names and compilation breaks in other code #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes in this PR:
stlab*symbols toadobe*inenum_ops.hppso it does not conflict with stlab's definitions when the two libraries coexist.modifiers_tso it will compile correctly when used by MSVC. There are some long-defunct Adobe Platform Libraries files that we still have to compile (unfortunately) that are now breaking when using newer releases of ASL & MSVC:[2024-06-28T02:41:28.820Z] [MB: 16028ms][DEBUG] [9]D:\path\to\adobe_platform_libraries\adobe\future\widgets\sources\button_helper.cpp(41,65): error C2440: 'return': cannot convert from 'int' to 'adobe::modifiers_t' [D:\path\to\adobe_platform_libraries.vcxproj]This fixes those compiler breaks long enough for us to revisit and remove those APL dependencies in a latter phase of our work.
These changes are on behalf of @baheath, who did the lion's share of compiler wrangling.