Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete APIs from task.hpp #112

Merged

Conversation

bheath-adobe
Copy link
Contributor

Several cancellation-related APIs have been removed from Windows PPL:

  • is_task_cancellation_requested
  • run_with_cancellation_token

Remove these and related code from task.hpp.

Several cancellation-related APIs have been removed from Windows PPL:
- is_task_cancellation_requested
- run_with_cancellation_token

Remove these are related code from task.hpp.
Copy link
Member

@sean-parent sean-parent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this means all the cancelation scope code in details also goes away. Go ahead and pull that out.

@sean-parent sean-parent merged commit feb4b46 into stlab:main Apr 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants