Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore comments when parsing Expression. #23

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: ignore comments when parsing Expression. #23

merged 2 commits into from
May 1, 2024

Conversation

peterhuene
Copy link
Collaborator

@peterhuene peterhuene commented Apr 30, 2024 •
edited
Loading

This commit fixes the incorrect filter when iterating over the pairs provided to the parse function for Expression.

Fixes #21.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.
  • Your changes are squashed into a single commit (unless there is a really
    good, articulated reason as to why there shouldn be more than one).

@peterhuene peterhuene mentioned this pull request Apr 30, 2024
Closed
@peterhuene
fix: ignore comments when parsing Expression.
f2d0436 
This commit fixes the incorrect filter when iterating over the pairs
provided to the `parse` function for `Expression`.

Fixes stjude-rust-labs#21.
claymcleod
claymcleod approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@claymcleod claymcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wdl-ast/CHANGELOG.md Outdated Show resolved Hide resolved
@peterhuene @claymcleod
Update wdl-ast/CHANGELOG.md
e621423 
Co-authored-by: Clay McLeod <3411613+claymcleod@users.noreply.github.com>
@peterhuene peterhuene merged commit b3d1106 into stjude-rust-labs:main May 1, 2024
6 checks passed
@peterhuene peterhuene deleted the fix-comments branch May 1, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claymcleod claymcleod claymcleod approved these changes

Assignees

@peterhuene peterhuene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Error parsing comment in multi-line boolean expression
2 participants
@peterhuene @claymcleod