-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lint warning for newline_eof #18
Conversation
Updated the PR. The only thing that I am unsure about is for Gauntlet. I am running |
f20c805
to
5dd1555
Compare
This commit squashes the following commits: * docs: updating Changelog * feat: newline_eof logic and doc update * feat: updating newline_eof tests * feat: updating gauntlet.toml for newline_eof
5dd1555
to
8d31840
Compare
@simojoe FYI, you may set the |
This pull request adds a new rule to
wdl
.newline_eof
v1::W007
wdl-grammar
This rule is currently written as to avoid missing newline at the end of WDL files.
My interpretation of the rule is that a WDL file should not end with an empty line (double newline symbols), but the rule description is not explicit about that (or the opposite situation).
The implementation currently checks two things :
Let me know if this implementation is not suitable
Before submitting this PR, please make sure:
CHANGELOG.md
(see["keep a changelog"] for more information).
good, articulated reason as to why there shouldn be more than one).
Rule specific checks:
tables (
wdl-ast/src/v1.rs
for AST-based rules andwdl-grammar/src/v1.rs
for parse tree-based rules).table at
RULES.md
.fn rules()
.wdl-ast
should be added tofn rules()
withinwdl-ast/src/v1/validation.rs
.wdl-ast
should be added tofn rules()
withinwdl-ast/src/v1/lint.rs
.wdl-grammar
should be added tofn rules()
withinwdl-grammar/src/v1/validation.rs
.wdl-grammar
should be added tofn rules()
withinwdl-grammar/src/v1/lint.rs
.within the file where the rule is implemented.