feat: explain command #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adthrasher
reviewed
May 31, 2024
Co-Authored-By: Andrew Thrasher <1165729+adthrasher@users.noreply.github.com>
peterhuene
approved these changes
Jun 3, 2024
adthrasher
approved these changes
Jun 3, 2024
|
I think we can live with the two The solution will be to have a single list of lint rules moving forward in the new implementation, where everything is based off the AST. I'm hoping that we might even put them in their own crate, such as |
adthrasher
reviewed
Jun 3, 2024
Co-Authored-By: Andrew Thrasher <1165729+adthrasher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the functionality changes here are quite straightforward. I added a new dependency,
colored, in order to get some "prettier" explain output. Maybe there's more we can do in that direction?