This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Tag outputs #256
Merged
Tag outputs #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need a commit message that informs of design decisions please. |
skrawcz
reviewed
Dec 23, 2022
elijahbenizzy
force-pushed
the
tag_nodes
branch
5 times, most recently
from
d7e3398 to
5c9f8ba
Compare
skrawcz
approved these changes
Dec 23, 2022
decorators.md
Outdated
| ### @tag_outputs | ||
|
|
||
| `tag_outputs` enables you to attach metadata to a function that outputs multiple nodes, | ||
| and give different tag values to different items: |
There was a problem hiding this comment.
Suggested change
| and give different tag values to different items: | |
| and give different tag values to different outputs: |
items isn't a term we use.
decorators.md
Outdated
| ## @tag | ||
| ## @tag and friends | ||
|
|
||
| ### @tag | ||
|
|
||
| Allows you to attach metadata to a node (any node decorated with the function). |
There was a problem hiding this comment.
Suggested change
| Allows you to attach metadata to a node (any node decorated with the function). | |
| Allows you to attach metadata to an output(s), i.e. all nodes generated by a function and its decorators. |
decorators.md
Outdated
Comment on lines
365
to
374
| @extract_columns('public', 'private') | ||
| def data_used_in_multiple_ways() -> pd.DataFrame: | ||
| return load_some_data(...) | ||
| ``` | ||
|
|
||
| In the case above, `common_tag` would resolve to `foo` for `public` and `bar` for `private`. | ||
| Attempting an override in the reverse direction is currently undefined behavior. |
There was a problem hiding this comment.
Suggested change
| @extract_columns('public', 'private') | |
| def data_used_in_multiple_ways() -> pd.DataFrame: | |
| return load_some_data(...) | |
| ``` | |
| In the case above, `common_tag` would resolve to `foo` for `public` and `bar` for `private`. | |
| Attempting an override in the reverse direction is currently undefined behavior. | |
| @extract_columns('column_a', 'column_b') | |
| def data_used_in_multiple_ways() -> pd.DataFrame: | |
| return load_some_data(...) | |
| ``` | |
| In the case above, `common_tag` would resolve to `foo` for `column_a` and `bar` for `column_b`. | |
| Attempting an override in the reverse direction is currently undefined behavior. |
elijahbenizzy
force-pushed
the
tag_nodes
branch
from
5c9f8ba to
dadd319
Compare
Solves #254 `tag_outputs` enables you to attach metadata to a function that outputs multiple nodes, and give different tag values to different items. This can be applied multiple times, and precedence order of the `tag` family of nodes is in reverse application order (see docs). Note that if we have `tag` before `tag_outputs` this is undefined behavior.
elijahbenizzy
force-pushed
the
tag_nodes
branch
from
dadd319 to
7b7ee35
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #254