This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
@does + default kwargs don't work #185
Labels
bug
Something isn't working
Comments
Closed
elijahbenizzy
added a commit
that referenced
this issue
Aug 22, 2022
Need to add a few more pieces to make this work -- this is a WIP.
elijahbenizzy
added a commit
that referenced
this issue
Aug 22, 2022
Need to add a few more pieces to make this work -- this is a WIP.
elijahbenizzy
added a commit
that referenced
this issue
Aug 24, 2022
elijahbenizzy
added a commit
that referenced
this issue
Aug 24, 2022
elijahbenizzy
added a commit
that referenced
this issue
Aug 26, 2022
…eadable. Adds the following features for #186: 1. The ability to have more complex arguments 2. The ability to have an argument mapping All of this is documented. Note we remove the typing constraint checking for the replacing function. This enables more complex polymorphically applicable functions without the pain of implementing sophisticated type-checking. Note this also fixes it breaking with optional dependencies (#185)
This is fixed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Short description explaining the high-level reason for the new issue.
Current behavior
It breaks, dependencies marked as optional are not carried over.
Stack Traces
(If applicable)
Screenshots
(If applicable)
Steps to replicate behavior
Library & System Information
E.g. python version, hamilton library version, linux, etc.
Expected behavior
This should work
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: