This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Helps fix #26 by making them optional dependencies
To ensure a delightful user experience, this commit adds to `extras_require` for graphviz and networkx. This will mean that users will have to do pip install sf-hamilton[visualization] to be able to get a DAG visualized. Rather than doing a major version bump, we're doing a minor one; this shouldn't break any body's core use, since they shouldn't be visualizing the DAG in production each time. Otherwise this updates the docs with this information. Adjusts behavior when graphivz or networkx aren't present Rather than causing an execute to fail, we'll instead log the error and return early. The message to the user should look something like: ``` ERROR:hamilton.graph: graphviz is required for visualizing the function graph. Install it with: pip install sf-hamilton[visualization] or pip install graphviz Traceback (most recent call last): File "/Users/stefankrawczyk/temp/hamilton/hamilton/graph.py", line 142, in display import graphviz ModuleNotFoundError: No module named 'graphviz' ```
- Loading branch information
Showing
5 changed files
with
25 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
VERSION = (1, 1, 1) | ||
VERSION = (1, 2, 0) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters