allow targets to be dynamically added and removed to the DOM #19

bellenss · 2022-07-03T07:11:29Z

This is a request to extend use of the the Stimulus lifecycle callbacks, to make the controller function properly when checkbox checkboxAll targets are dynamically added and/or removed from the DOM.
Use cases is dynamically updating list content with Turbo streams in Rails.

guillaumebriday · 2022-12-23T21:30:11Z

That's nice, thanks @bellenss

guillaumebriday · 2022-12-23T21:56:16Z

We can also remove the connect and disconnect method for the controller with this PR 👍

I will do it in another PR

guillaumebriday · 2022-12-23T23:04:45Z

Released in https://github.com/stimulus-components/stimulus-checkbox-select-all/releases/tag/v5.2.0

allow targets to be dynamically added and removed to the DOM

7770219

guillaumebriday self-assigned this Dec 23, 2022

guillaumebriday self-requested a review December 23, 2022 21:29

guillaumebriday merged commit f3f0e21 into stimulus-components:master Dec 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow targets to be dynamically added and removed to the DOM #19

allow targets to be dynamically added and removed to the DOM #19

bellenss commented Jul 3, 2022 •

edited

Loading

guillaumebriday commented Dec 23, 2022

guillaumebriday commented Dec 23, 2022

guillaumebriday commented Dec 23, 2022

allow targets to be dynamically added and removed to the DOM #19

allow targets to be dynamically added and removed to the DOM #19

Conversation

bellenss commented Jul 3, 2022 • edited Loading

guillaumebriday commented Dec 23, 2022

guillaumebriday commented Dec 23, 2022

guillaumebriday commented Dec 23, 2022

bellenss commented Jul 3, 2022 •

edited

Loading