Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate deprecation warnings in Julia v0.6 #2

Merged
merged 1 commit into from
Jun 10, 2017

Conversation

wsshin
Copy link
Collaborator

@wsshin wsshin commented Jun 10, 2017

This PR eliminates various deprecation warnings in Julia v0.6 while keeping it compatible with v0.5.

Change summary:

  • Use dot syntax for min, max, sqrt, etc
  • sumabs2sum(abs2, ...)
  • abstract TypeName@compat abstract type TypeName end
  • The v0.6 inner constructor syntax cannot be used even with the Compat package (see here), so use the workaround suggested here.

@wsshin wsshin mentioned this pull request Jun 10, 2017
@codecov-io
Copy link

codecov-io commented Jun 10, 2017

Codecov Report

Merging #2 into master will decrease coverage by 1.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   85.04%   83.48%   -1.57%     
==========================================
  Files           6        6              
  Lines         107      109       +2     
==========================================
  Hits           91       91              
- Misses         16       18       +2
Impacted Files Coverage Δ
src/GeometryPrimitives.jl 100% <ø> (ø) ⬆️
src/sphere.jl 100% <100%> (ø) ⬆️
src/kdtree.jl 74.5% <100%> (-3.5%) ⬇️
src/box.jl 93.75% <100%> (ø) ⬆️
src/ellipsoid.jl 100% <100%> (ø) ⬆️
src/cylinder.jl 84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f42f2...d51dea1. Read the comment docs.

@stevengj stevengj merged commit 25ed6b7 into stevengj:master Jun 10, 2017
@stevengj
Copy link
Owner

Thanks!

@wsshin wsshin deleted the compat-with-v0.6 branch June 15, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants