Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report proper height of text being edited #132

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Report proper height of text being edited #132

merged 1 commit into from
Aug 23, 2023

Conversation

stevengharris
Copy link
Owner

No description provided.

@stevengharris stevengharris merged commit 4c0fcf1 into main Aug 23, 2023
@stevengharris
Copy link
Owner Author

Hey @JohnKuan, just FYI on this update, which was needed as a byproduct of the fix for #106. By putting in the padding-block to the editor CSS, the height of the text was being reported as the full screen height. The app I am using MarkupEditor in uses the height to auto-size the MarkupWKWebView, so it was a little broken by the change 😜. I tried to ensure the fix here did not regress the other, but you might want to double-check.

@stevengharris stevengharris linked an issue Aug 23, 2023 that may be closed by this pull request
Height is reported incorrectly #131
Closed
@JohnKuan
Copy link
Contributor

Hi @stevengharris, thanks for the heads up. Though I have not encounter this issue visually, I will check it as well.

@stevengharris stevengharris deleted the heightNoPadding branch September 4, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Height is reported incorrectly
2 participants
@stevengharris @JohnKuan