Fix incorrect directory pruning, simplify path handling #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muescha
reviewed
Feb 5, 2019
rwe
commented
Feb 5, 2019
This allows the paths to be pruned more quickly and reduces the need for the md5-variable-name juggling.
|
This has been rebased |
|
@rwe, my sincerest apologies that this has taken forever and a day to get to, but this looks awesome, thank you so much for your contribution (and patience)!! |
|
No worries, there was no rush. Thanks for getting to it and for the useful tool! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some paths were not being visited correctly: search was pruned when a directory name matched, but before checking if the sentinel file existed.
This PR simplifies a number of elements of the implementation by running the sentinel file check via find's
-execdir. The approach removes the need for the dynamic bash variables etc and should also speed up searches.This includes some minor code cleanups while I was investigating various approaches.