better msg if logs are unavailable (closes #1503) #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goekay I think it is better but the log section could be hidden when not available too. |
sure, the way to do is as follows: expose the condition to hide in a model parameter (e.g. the profile steve runs at), and put this line behind that condition. but, when switching between profiles the header sequence would not be consistent (sometimes log is there, sometimes not, ...). i would argue that this could cause a confusion as well: why is this happening? with the solution from this PR, we would be telling the why to the user. |
Closed
juherr
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juherr @lmccarty5 would this be an improvement?