Clean the database part of build #1455
Conversation
(cherry picked from commit 37ee40cd6a5cda20f7591cbaa3f2a25bdc2c78a0)
|
|
||
| - name: Build with Maven | ||
| run: ./mvnw -B -V -Dmaven.javadoc.skip=true -Ptest clean package --file pom.xml | ||
| run: ./mvnw -B -V -Dmaven.javadoc.skip=true -Ddb-user=$DB_USER -Ddb-password=$DB_PASSWORD -Ddb-schema=$DB_SCHEMA -Ptest clean package --file pom.xml |
There was a problem hiding this comment.
Enforce user/password/schema
| RUN sed -i 's|${db.port}|${env.DB_PORT}|g' pom.xml | ||
| RUN sed -i 's|${db.user}|${env.DB_USERNAME}|g' pom.xml | ||
| RUN sed -i 's|${db.password}|${env.DB_PASSWORD}|g' pom.xml | ||
| RUN sed -i 's|${db.schema}|${env.DB_DATABASE}|g' pom.xml |
There was a problem hiding this comment.
env are directly managed by maven
| @@ -245,26 +281,6 @@ | |||
| </configuration> | |||
| </plugin> | |||
|
|
|||
| <!-- Read from main.properties the DB configuration --> | |||
| <plugin> | |||
| <groupId>org.codehaus.mojo</groupId> | |||
There was a problem hiding this comment.
main.properties is for runtime only and generated by maven
|
@goekay wdyt? |
|
Ping @goekay |
|
can you please elaborate the motivation and the problem you are trying to solve? |
|
When I first started working on this project as a newcomer, I found it quite challenging to understand how to correctly run it due to its deviation from standard conventions. The main issue lies in the confusion between compile time and runtime. The purpose of this Pull Request is to address this problem by creating a clear distinction between the compilation and execution phases, thereby enhancing the project's manageability. |
|
Ping @goekay |
|
This would be nice, consolidating the env var setting in one location. |
No description provided.