Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community feedback wanted: Migrate from Java 11 to Java 17 #895

Closed
goekay opened this issue Sep 3, 2022 · 5 comments · Fixed by #1348
Closed

Community feedback wanted: Migrate from Java 11 to Java 17 #895

goekay opened this issue Sep 3, 2022 · 5 comments · Fixed by #1348

Comments

@goekay
Copy link
Member

goekay commented Sep 3, 2022

Hey all,

our Java version, Java 11, has been released in 2018. Java 17 has been released in 2021. Both are LTS. I want to migrate the project to Java 17 because there is some momentum behind it:

  1. JooQ (our DB abstraction layer) made it the baseline for new versions [source]. Because of this we cannot update it and merge automatic PRs from dependabot starting with this.
  2. Next Spring version will be released in Q4 2022. Java 17 will be the baseline for Spring 6: https://spring.io/blog/2021/09/02/a-java-17-and-jakarta-ee-9-baseline-for-spring-framework-6

The cadence of new Java version releases increased in recent years. The migrations from an older to a newer release are less of an issue for users.

Feedback and ideas are welcome. Are you okay with this?

@juherr
Copy link
Contributor

juherr commented Sep 5, 2022

A rule we use at @testng-team is: only need to support the 2 last LTS.
But TestNG is a library, not a project.

The latest LTS is supposed to be enough for a free hobby project.
If someone can't use the latest Java LTS version, I suppose they can pay for its support.

Maybe a features/java17-migration branch with the changes could help to provide more feedback.

@csamsel
Copy link
Contributor

csamsel commented Sep 12, 2022

the latest raspian version is based on debian 11 which comes by default with java 11. Ubuntu LTS 20.04 which is also still quiet common as base image e.g. in Azure also comes with java 11 (22.04 comes with java 17).

So it would be some hassle for a lot of users. I would wait a bit more.

@lategoodbye
Copy link
Contributor

FWIW I successfully tested Steve 3.4.9 with Debian 11 and OpenJDK 17.0.4 (amd64), which is also available via apt.

@goekay
Copy link
Member Author

goekay commented Nov 20, 2022

just as a note: spring 6 is out and PRs created by dependabot started failing. example: #971

@keeth
Copy link

keeth commented Jan 14, 2023

Upgrade to Java 17 sounds good to me!

goekay added a commit that referenced this issue Jan 5, 2024
@goekay goekay linked a pull request Jan 5, 2024 that will close this issue
goekay added a commit that referenced this issue Jan 5, 2024
goekay added a commit that referenced this issue Jan 6, 2024
* #895: switch to java 17
* #895: update readme
* add java 21 to github actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants