Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the Server Management Modal #1783

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Enhance the Server Management Modal #1783

merged 2 commits into from
Mar 22, 2024

Conversation

mabasian
Copy link
Contributor

@mabasian mabasian commented Mar 20, 2024 •
edited
Loading

Fix #1782

@mabasian mabasian requested a review from daGscheid March 20, 2024 17:41
@mabasian mabasian marked this pull request as draft March 20, 2024 17:56
daGscheid
daGscheid previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@daGscheid daGscheid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, thank you 🙏

Edit: Will do the next one as well 😄

@mabasian mabasian marked this pull request as ready for review March 20, 2024 19:34
@mabasian mabasian marked this pull request as draft March 21, 2024 09:38
@mabasian mabasian requested a review from daGscheid March 21, 2024 13:13
@mabasian mabasian marked this pull request as ready for review March 21, 2024 13:13
daGscheid
daGscheid approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@daGscheid daGscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daGscheid daGscheid merged commit 156a8c9 into stereum-dev:main Mar 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daGscheid daGscheid daGscheid approved these changes

@gbayasgalan gbayasgalan Awaiting requested review from gbayasgalan

@NeoPlays NeoPlays Awaiting requested review from NeoPlays

@daverolo daverolo Awaiting requested review from daverolo

@PatrickRL PatrickRL Awaiting requested review from PatrickRL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Sever Management Modal acessible despite offline / reconnect state
2 participants
@mabasian @daGscheid