Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Custom Service #1705

Merged
merged 18 commits into from
Mar 12, 2024
Merged

ADD: Custom Service #1705

merged 18 commits into from
Mar 12, 2024

Conversation

NeoPlays
Copy link
Member

This PR introduces the basic implementation of #1463
some UI to consider:

  • Input for Volumes
  • Input for Ports
  • Easy connections to other clients (will take quite some more effort)
  • Set category (easy to implement, will intruduce painful bugs)

@NeoPlays NeoPlays marked this pull request as ready for review March 8, 2024 09:08
gbayasgalan
gbayasgalan previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@gbayasgalan gbayasgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MaxTheGeeek MaxTheGeeek requested a review from gbayasgalan March 12, 2024 09:29
@daGscheid daGscheid merged commit 4d2b2fb into stereum-dev:main Mar 12, 2024
3 checks passed
@daGscheid daGscheid mentioned this pull request Mar 12, 2024
Closed
2 tasks
@NeoPlays NeoPlays deleted the custom-image branch March 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbayasgalan gbayasgalan gbayasgalan approved these changes

@domioiRL domioiRL Awaiting requested review from domioiRL

@daverolo daverolo Awaiting requested review from daverolo

@M4r71nW M4r71nW Awaiting requested review from M4r71nW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NeoPlays @gbayasgalan @daGscheid @MaxTheGeeek