Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External connection #1664

Merged
merged 61 commits into from
Feb 2, 2024
Merged

External connection #1664

merged 61 commits into from
Feb 2, 2024

Conversation

gbayasgalan
Copy link
Contributor

@gbayasgalan gbayasgalan commented Feb 1, 2024 •
edited
Loading

resolved: #1113 still missing --beacon-rpc-gateway-provider= of Prysm

gbayasgalan and others added 30 commits January 18, 2024 17:53
@gbayasgalan
init
8c39c8c
@gbayasgalan
Merge branch 'stereum-dev:main' into external-connection
1204ebe
@gbayasgalan
init
f259f5c
@gbayasgalan
Merge branch 'stereum-dev:main' into external-connection
688c6dc
@mabasian
Fix the external connections' Frontend
434de2a
@mabasian
Merge branch 'external-connection' of https://github.com/gbayasgalan/…
9fd326f 
…ethereum-node into external-connection
@gbayasgalan
Merge branch 'stereum-dev:main' into external-connection
1d73c01
@gbayasgalan
Merge branch 'stereum-dev:main' into external-connection
cffcd88
@gbayasgalan
Merge branch 'stereum-dev:main' into external-connection
e651868
@gbayasgalan
init
67ee302
@MaxTheGeeek
MODIFY: specificly for external
4ca6054
@MaxTheGeeek
MODIFY: specifically for external service
00ec5de
@MaxTheGeeek
ADD: external in 2 categories
4bdfc92
@gbayasgalan
MODIFY: external service into separate services
cf288eb
@MaxTheGeeek
FIX: external button on node
c83f449
@MaxTheGeeek
FIX: external button on contol page
d5904bc
@MaxTheGeeek
FIX: external button on contol
80f838f
@MaxTheGeeek
FIX: external btn on control
d43368c
@MaxTheGeeek
FIX: external btn
eb3b5a5
@MaxTheGeeek
FIX: connection panel
3cf42a0
@MaxTheGeeek
FIX: connection for external
32ba8bd
@MaxTheGeeek
ADD: external connection filter
aa4215b
@gbayasgalan
MODIFY: service init config & tiny fix on frontend
778a4a0
@gbayasgalan
Merge branch 'stereum-dev:main' into external-connection
731fc29
@gbayasgalan
ADD: function to get inputs
e255852
@MaxTheGeeek
ADD: external sources
308421e
@gbayasgalan
FIX: tiny fix
5e121a5
@gbayasgalan
ADD: save external link & jwt on the server
25b9d53
@gbayasgalan
Merge branch 'stereum-dev:main' into external-connection
bf773b6
@MaxTheGeeek
ADD: compy icon & func
e071267
MaxTheGeeek
MaxTheGeeek previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@MaxTheGeeek MaxTheGeeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

NeoPlays
NeoPlays requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@NeoPlays NeoPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls look at the comments, and ask me if something is not clear :^)

launcher/package.json Outdated Show resolved Hide resolved
launcher/src/backend/ethereum-services/CharonService.js Outdated Show resolved Hide resolved
launcher/src/backend/ethereum-services/ExternalConsensusService.js Outdated Show resolved Hide resolved
launcher/src/backend/ethereum-services/LighthouseBeaconService.js Outdated Show resolved Hide resolved
launcher/src/background.js Outdated Show resolved Hide resolved
launcher/src/components/UI/edit-page/components/modals/AddModal.vue Outdated Show resolved Hide resolved
launcher/src/components/UI/edit-page/components/modals/AddPanel.vue Outdated Show resolved Hide resolved
launcher/src/components/UI/edit-page/components/modals/AddPanel.vue Outdated Show resolved Hide resolved
@NeoPlays
Copy link
Member

NeoPlays commented Feb 2, 2024

solved: #1113 still missing --beacon-rpc-gateway-provider= of Prysm

prysm VCs can only connect to prysm CCs. (for now)

@gbayasgalan
Copy link
Contributor Author

solved: #1113 still missing --beacon-rpc-gateway-provider= of Prysm

prysm VCs can only connect to prysm CCs. (for now)

got it thanks. atm there is a no "input" for --beacon-rpc-gateway-provider, we can do this optional for externalConsensus

NeoPlays
NeoPlays requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@NeoPlays NeoPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i found one more thing. but the rest looks good :)

launcher/src/backend/ServiceManager.js Show resolved Hide resolved
@gbayasgalan gbayasgalan requested a review from NeoPlays February 2, 2024 15:34
NeoPlays
NeoPlays approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@NeoPlays NeoPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@gbayasgalan gbayasgalan merged commit 09d3d99 into stereum-dev:main Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeoPlays NeoPlays NeoPlays approved these changes

@daverolo daverolo Awaiting requested review from daverolo

@MaxTheGeeek MaxTheGeeek Awaiting requested review from MaxTheGeeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: Enable A Simply Way To Add External Client Connection
4 participants
@gbayasgalan @NeoPlays @MaxTheGeeek @mabasian