Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: restructure UI of Staking Page #1537

Merged
merged 209 commits into from
Dec 22, 2023
Merged

REFACTOR: restructure UI of Staking Page #1537

merged 209 commits into from
Dec 22, 2023

Conversation

MaxTheGeeek
Copy link
Contributor

@MaxTheGeeek MaxTheGeeek commented Nov 6, 2023 •
edited
Loading

Staking Page UI Restructuring - Task List

Tasks

  • Add base Layout to staking page
  • Reduced the size of components in the staking page to improve the layout.
  • Structured the project files and components into separate folders for better organization.
  • Skeleton preloading
  • Epoch & Rewards
  • Change panels structure
  • Custom modal as a basic layout for modals
  • Add grouping validator keys, panel & functionality
  • Add import remote key as a panel
  • Verified that the functions work and the organization did not break any functionality.

@MaxTheGeeek MaxTheGeeek requested a review from NeoPlays November 6, 2023 13:13
@MaxTheGeeek MaxTheGeeek changed the title Refactor: restructure UI of Staking Page REFACTOR: restructure UI of Staking Page Nov 6, 2023
gbayasgalan and others added 24 commits December 20, 2023 12:57
@gbayasgalan
Merge branch 'staking' of https://github.com/MaxTheGeeek/ethereum-node …
114737f 
…into staking
@gbayasgalan
EDIT: remove comment
2dc42a1
@gbayasgalan
removing logs
71d75e8
@MaxTheGeeek
ADD: truncate fn in composables
b4e9891
@MaxTheGeeek
ADD: response details to exit modal
d33748f
@MaxTheGeeek
Merge branch 'staking' of https://github.com/MaxTheGeeek/ethereum-node …
1f7f545 
…into staking
@MaxTheGeeek
FIX: withdraw function from group list
d8c4499
@MaxTheGeeek
FIX: icons d & d
2ba5d94
@MaxTheGeeek
ADD: disabled staking
9a0ee35
@MaxTheGeeek
ADD: dummy value to rewards
4b7131f
@MaxTheGeeek
ADD: disabled staking on no validator client
353e5b4
@MaxTheGeeek
ADD: disabled user commands btns on no keys
b5072ca
@MaxTheGeeek
FIX: no drag
5feb34e
@gbayasgalan
fix: disable text select
e78bd35
@MaxTheGeeek
FIX: selectable texts on edit node
ab32d8d
@MaxTheGeeek
Merge branch 'staking' of https://github.com/MaxTheGeeek/ethereum-node …
303fa31 
…into staking
@MaxTheGeeek
ADD: client commands conditions
a69a928
@MaxTheGeeek
FIX: conditions
4ff943f
@gbayasgalan
FIX: fee recipientAddress functionality
a6e4348
@MaxTheGeeek
FIX: some fixes
7c749a4
@MaxTheGeeek
FIX: disabled panel btn during importing key
0ca9247
@gbayasgalan
ADD: user select to base
2828615
@MaxTheGeeek
Merge branch 'main' into staking
11d13f3
@MaxTheGeeek
FIX: eslint
e6b0ef9
@MaxTheGeeek MaxTheGeeek marked this pull request as ready for review December 22, 2023 13:48
gbayasgalan
gbayasgalan approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@gbayasgalan gbayasgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gbayasgalan gbayasgalan merged commit 6134524 into stereum-dev:main Dec 22, 2023
3 checks passed
MaxTheGeeek added a commit that referenced this pull request Dec 27, 2023
@MaxTheGeeek
Revert "REFACTOR: restructure UI of Staking Page (#1537)"
5a0626c 
This reverts commit 6134524.
@MaxTheGeeek MaxTheGeeek mentioned this pull request Dec 27, 2023
Merged
MaxTheGeeek added a commit that referenced this pull request Dec 27, 2023
@MaxTheGeeek
Revert "REFACTOR: restructure UI of Staking Page (#1537)" (#1607)
7b14386 
This reverts commit 6134524.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbayasgalan gbayasgalan gbayasgalan approved these changes

@NeoPlays NeoPlays Awaiting requested review from NeoPlays

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxTheGeeek @gbayasgalan @NeoPlays